Commit fff6e6ac authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

ipv6: anycast: use call_rcu_hurry() in aca_put() 



This is a followup of commit b5327b9a ("ipv6: use
call_rcu_hurry() in fib6_info_release()").

I had another pmtu.sh failure, and found another lazy
call_rcu() causing this failure.

aca_free_rcu() calls fib6_info_release() which releases
devices references.

We must not delay it too much or risk unregister_netdevice/ref_tracker
traces because references to netdev are not released in time.

This should speedup device/netns dismantles when CONFIG_RCU_LAZY=y

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reviewed-by: default avatarDavid Ahern <dsahern@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c2e6a872

net/ipv6/anycast.c

+2 −3
Original line number Diff line number Diff line
@@ -252,9 +252,8 @@ static void aca_free_rcu(struct rcu_head *h) 


static void aca_put(struct ifacaddr6 *ac)

{

	if (refcount_dec_and_test(&ac->aca_refcnt)) {

		call_rcu(&ac->rcu, aca_free_rcu);

	}

	if (refcount_dec_and_test(&ac->aca_refcnt))

		call_rcu_hurry(&ac->rcu, aca_free_rcu);

}



static struct ifacaddr6 *aca_alloc(struct fib6_info *f6i,