Commit 0b51ba07 authored by Adrian Bunk's avatar Adrian Bunk Committed by Jaroslav Kysela
Browse files

[ALSA] make sound/core/control.c:snd_ctl_new() static 



Now that everyone uses snd_ctl_new1() and noone is using snd_ctl_new()
anymore, we can make it static.

Signed-off-by: default avatarAdrian Bunk <bunk@stusta.de>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarJaroslav Kysela <perex@suse.cz>
parent 5cd57529

Documentation/sound/alsa/DocBook/writing-an-alsa-driver.tmpl

+0 −10
Original line number Diff line number Diff line
@@ -3690,16 +3690,6 @@ struct _snd_pcm_runtime { 
          </example>

        </para>



        <para>

          Here, the chip instance is retrieved via

        <function>snd_kcontrol_chip()</function> macro.  This macro

        just accesses to kcontrol-&gt;private_data. The

        kcontrol-&gt;private_data field is 

        given as the argument of <function>snd_ctl_new()</function>

        (see the later subsection

        <link linkend="control-interface-constructor"><citetitle>Constructor</citetitle></link>).

        </para>



        <para>

	The <structfield>value</structfield> field is depending on

        the type of control as well as on info callback.  For example,

include/sound/control.h

+0 −1
Original line number Diff line number Diff line
@@ -108,7 +108,6 @@ typedef int (*snd_kctl_ioctl_func_t) (struct snd_card * card, 


void snd_ctl_notify(struct snd_card * card, unsigned int mask, struct snd_ctl_elem_id * id);



struct snd_kcontrol *snd_ctl_new(struct snd_kcontrol * kcontrol, unsigned int access);

struct snd_kcontrol *snd_ctl_new1(const struct snd_kcontrol_new * kcontrolnew, void * private_data);

void snd_ctl_free_one(struct snd_kcontrol * kcontrol);

int snd_ctl_add(struct snd_card * card, struct snd_kcontrol * kcontrol);

sound/core/control.c

+2 −3
Original line number Diff line number Diff line
@@ -183,7 +183,8 @@ EXPORT_SYMBOL(snd_ctl_notify); 
 *

 * Returns the pointer of the new instance, or NULL on failure.

 */

struct snd_kcontrol *snd_ctl_new(struct snd_kcontrol *control, unsigned int access)

static struct snd_kcontrol *snd_ctl_new(struct snd_kcontrol *control,

					unsigned int access)

{

	struct snd_kcontrol *kctl;

	unsigned int idx;
@@ -201,8 +202,6 @@ struct snd_kcontrol *snd_ctl_new(struct snd_kcontrol *control, unsigned int acce 
	return kctl;

}



EXPORT_SYMBOL(snd_ctl_new);



/**

 * snd_ctl_new1 - create a control instance from the template

 * @ncontrol: the initialization record