Commit 19b4fc52 authored by Denis V. Lunev's avatar Denis V. Lunev Committed by Linus Torvalds
Browse files

reiserfs: use non-racy method for proc entries creation 



Use proc_create()/proc_create_data() to make sure that ->proc_fops and ->data
be setup before gluing PDE to main tree.

/proc entry owner is also added.

Signed-off-by: default avatarDenis V. Lunev <den@openvz.org>
Cc: Jeff Mahoney <jeffm@suse.com>
Cc: Chris Mason <chris.mason@oracle.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 46fe74f2

fs/reiserfs/procfs.c

+3 −6
Original line number Diff line number Diff line
@@ -467,6 +467,7 @@ static const struct file_operations r_file_operations = { 
	.read = seq_read,

	.llseek = seq_lseek,

	.release = seq_release,

	.owner = THIS_MODULE,

};



static struct proc_dir_entry *proc_info_root = NULL;
@@ -475,12 +476,8 @@ static const char proc_info_root_name[] = "fs/reiserfs"; 
static void add_file(struct super_block *sb, char *name,

		     int (*func) (struct seq_file *, struct super_block *))

{

	struct proc_dir_entry *de;

	de = create_proc_entry(name, 0, REISERFS_SB(sb)->procdir);

	if (de) {

		de->data = func;

		de->proc_fops = &r_file_operations;

	}

	proc_create_data(name, 0, REISERFS_SB(sb)->procdir,

			 &r_file_operations, func);

}



int reiserfs_proc_info_init(struct super_block *sb)