git/linux-net
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/ synced 2026-04-23 08:55:56 -04:00
Code Issues Packages Projects Releases Wiki Activity

drm/mst: remove mgr parameter and debug logging from drm_dp_get_vc_payload_bw()

Browse Source 
The struct drm_dp_mst_topology_mgr *mgr parameter is only used for debug
logging in case the passed in link rate or lane count are zero. There's
no further error checking as such, and the function returns 0.

There should be no case where the parameters are zero. The returned
value is generally used as a divisor, and if we were hitting this, we'd
be seeing division by zero.

Just remove the debug logging altogether, along with the mgr parameter,
so that the function can be used in non-MST contexts without the
topology manager.

v2: Also remove drm_dp_mst_helper_tests_init as unnecessary (Imre)

Cc: Imre Deak <imre.deak@intel.com>
Cc: Lyude Paul <lyude@redhat.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/72d77e7a7fe69c784e9df048b7e6f250fd7599e4.1735912293.git.jani.nikula@intel.com
This commit is contained in:
Jani Nikula
2025-01-03 15:52:24 +02:00
parent 6f0f335b73
commit 79cb1fad39
5 changed files with 6 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/gpu/drm/tests/drm_dp_mst_helper_test.c
View File

@@ -199,10 +199,8 @@ static const struct drm_dp_mst_calc_pbn_div_test drm_dp_mst_calc_pbn_div_dp1_4_c
static void drm_test_dp_mst_calc_pbn_div(struct kunit *test)
{
const struct drm_dp_mst_calc_pbn_div_test *params = test->param_value;
/* mgr->dev is only needed by drm_dbg_kms(), but it's not called for the test cases. */
struct drm_dp_mst_topology_mgr *mgr = test->priv;
KUNIT_EXPECT_EQ(test, drm_dp_get_vc_payload_bw(mgr, params->link_rate, params->lane_count).full,
KUNIT_EXPECT_EQ(test, drm_dp_get_vc_payload_bw(params->link_rate, params->lane_count).full,
params->expected.full);
}
@@ -568,21 +566,8 @@ static struct kunit_case drm_dp_mst_helper_tests[] = {
{ }
};
static int drm_dp_mst_helper_tests_init(struct kunit *test)
{
struct drm_dp_mst_topology_mgr *mgr;
mgr = kunit_kzalloc(test, sizeof(*mgr), GFP_KERNEL);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, mgr);
test->priv = mgr;
return 0;
}
static struct kunit_suite drm_dp_mst_helper_test_suite = {
.name = "drm_dp_mst_helper",
.init = drm_dp_mst_helper_tests_init,
.test_cases = drm_dp_mst_helper_tests,
};