mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/
synced 2026-04-18 06:33:43 -04:00
0aaff7b109
Make use of empty (NULL-terminated) array instead of NULL pointer to
avoid compiler errors while maintaining the behavior of the function
intact
[] Testing:
The diff between before and after of running the kselftest test of the
module shows no regression on system with x86 architecture
[] Error log:
~/Desktop/kernel-dev/linux-v1/tools/testing/selftests/filesystems$ make LLVM=1 W=1
CC devpts_pts
CC file_stressor
CC anon_inode_test
anon_inode_test.c:45:37: warning: null passed to a callee that requires a non-null argument [-Wnonnull]
45 | ASSERT_LT(execveat(fd_context, "", NULL, NULL, AT_EMPTY_PATH), 0);
| ^~~~
/usr/lib/llvm-18/lib/clang/18/include/__stddef_null.h:26:14: note: expanded from macro 'NULL'
26 | #define NULL ((void*)0)
| ^~~~~~~~~~
../Desktop/kernel-dev/linux-v1/tools/testing/selftests/../../../tools/testing/selftests/kselftest_harness.h:535:11: note: expanded from macro 'ASSERT_LT'
535 | __EXPECT(expected, #expected, seen, #seen, <, 1)
| ^~~~~~~~
../Desktop/kernel-dev/linux-v1/tools/testing/selftests/../../../tools/testing/selftests/kselftest_harness.h:758:33: note: expanded from macro '__EXPECT'
758 | __typeof__(_expected) __exp = (_expected); \
| ^~~~~~~~~
1 warning generated.
Link: https://lore.kernel.org/r/20251215084900.7590-1-clintbgeorge@gmail.com
Signed-off-by: Clint George <clintbgeorge@gmail.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
73 lines
1.3 KiB
C
73 lines
1.3 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#define _GNU_SOURCE
|
|
#define __SANE_USERSPACE_TYPES__
|
|
|
|
#include <fcntl.h>
|
|
#include <stdio.h>
|
|
#include <sys/stat.h>
|
|
|
|
#include "kselftest_harness.h"
|
|
#include "wrappers.h"
|
|
|
|
TEST(anon_inode_no_chown)
|
|
{
|
|
int fd_context;
|
|
|
|
fd_context = sys_fsopen("tmpfs", 0);
|
|
ASSERT_GE(fd_context, 0);
|
|
|
|
ASSERT_LT(fchown(fd_context, 1234, 5678), 0);
|
|
ASSERT_EQ(errno, EOPNOTSUPP);
|
|
|
|
EXPECT_EQ(close(fd_context), 0);
|
|
}
|
|
|
|
TEST(anon_inode_no_chmod)
|
|
{
|
|
int fd_context;
|
|
|
|
fd_context = sys_fsopen("tmpfs", 0);
|
|
ASSERT_GE(fd_context, 0);
|
|
|
|
ASSERT_LT(fchmod(fd_context, 0777), 0);
|
|
ASSERT_EQ(errno, EOPNOTSUPP);
|
|
|
|
EXPECT_EQ(close(fd_context), 0);
|
|
}
|
|
|
|
TEST(anon_inode_no_exec)
|
|
{
|
|
int fd_context;
|
|
|
|
fd_context = sys_fsopen("tmpfs", 0);
|
|
ASSERT_GE(fd_context, 0);
|
|
|
|
char *const empty_argv[] = {NULL};
|
|
char *const empty_envp[] = {NULL};
|
|
|
|
ASSERT_LT(execveat(fd_context, "", empty_argv, empty_envp, AT_EMPTY_PATH), 0);
|
|
ASSERT_EQ(errno, EACCES);
|
|
|
|
EXPECT_EQ(close(fd_context), 0);
|
|
}
|
|
|
|
TEST(anon_inode_no_open)
|
|
{
|
|
int fd_context;
|
|
|
|
fd_context = sys_fsopen("tmpfs", 0);
|
|
ASSERT_GE(fd_context, 0);
|
|
|
|
ASSERT_GE(dup2(fd_context, 500), 0);
|
|
ASSERT_EQ(close(fd_context), 0);
|
|
fd_context = 500;
|
|
|
|
ASSERT_LT(open("/proc/self/fd/500", 0), 0);
|
|
ASSERT_EQ(errno, ENXIO);
|
|
|
|
EXPECT_EQ(close(fd_context), 0);
|
|
}
|
|
|
|
TEST_HARNESS_MAIN
|
|
|