Commit 00868d03 authored by Christian Marangi's avatar Christian Marangi Committed by Jakub Kicinski
Browse files

net: phy: mediatek: init val in .phy_led_polarity_set for AN7581 



Fix smatch warning for uninitialised val in .phy_led_polarity_set for
AN7581 driver.

Correctly init to 0 to set polarity high by default.

Reported-by: default avatarSimon Horman <horms@kernel.org>
Fixes: 6a325aed ("net: phy: mediatek: add Airoha PHY ID to SoC driver")
Signed-off-by: default avatarChristian Marangi <ansuelsmth@gmail.com>
Link: https://patch.msgid.link/20250415105313.3409-1-ansuelsmth@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 4cc8b577

drivers/net/phy/mediatek/mtk-ge-soc.c

+1 −2
Original line number Diff line number Diff line
@@ -1432,8 +1432,8 @@ static int an7581_phy_probe(struct phy_device *phydev) 
static int an7581_phy_led_polarity_set(struct phy_device *phydev, int index,

				       unsigned long modes)

{

	u16 val = 0;

	u32 mode;

	u16 val;



	if (index >= MTK_PHY_MAX_LEDS)

		return -EINVAL;
@@ -1444,7 +1444,6 @@ static int an7581_phy_led_polarity_set(struct phy_device *phydev, int index, 
			val = MTK_PHY_LED_ON_POLARITY;

			break;

		case PHY_LED_ACTIVE_HIGH:

			val = 0;

			break;

		default:

			return -EINVAL;