Unverified Commit 00c22b1e authored by Kaushlendra Kumar's avatar Kaushlendra Kumar Committed by Ilpo Järvinen
Browse files

platform/x86/intel/pmt: Fix kobject memory leak on init failure 



When kobject_init_and_add() fails in pmt_features_discovery(), the
function returns without calling kobject_put(). This violates the
kobject API contract where kobject_put() must be called even on
initialization failure to properly release allocated resources.

Fixes: d9a07880 ("platform/x86/intel/pmt: Add PMT Discovery driver")
Signed-off-by: default avatarKaushlendra Kumar <kaushlendra.kumar@intel.com>
Link: https://patch.msgid.link/20251223084041.3832933-1-kaushlendra.kumar@intel.com


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 20e20b14

drivers/platform/x86/intel/pmt/discovery.c

+3 −1
Original line number Diff line number Diff line
@@ -503,8 +503,10 @@ static int pmt_features_discovery(struct pmt_features_priv *priv, 


	ret = kobject_init_and_add(&feature->kobj, ktype, &priv->dev->kobj,

				   "%s", pmt_feature_names[feature->id]);

	if (ret)

	if (ret) {

		kobject_put(&feature->kobj);

		return ret;

	}



	kobject_uevent(&feature->kobj, KOBJ_ADD);

	pmt_features_add_feat(feature);