Commit 00ee2537 authored Jun 10, 2025 by Heiner Kallweit Committed by Jakub Kicinski Jun 12, 2025

net: phy: move definition of genphy_c45_driver to phy_device.c



genphy_c45_read_status() is exported, so we can move definition of
genphy_c45_driver to phy_device.c and make it static. This helps
to clean up phy.h a little.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/ead3ab17-22d0-4cd3-901c-3d493ab851e6@gmail.com


Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 94a8e4a8

drivers/net/phy/phy-c45.c

+0 −7

Original line number	Diff line number	Diff line
		@@ -1573,10 +1573,3 @@ int genphy_c45_ethtool_set_eee(struct phy_device *phydev,
		return ret;
		}
		EXPORT_SYMBOL(genphy_c45_ethtool_set_eee);

		struct phy_driver genphy_c45_driver = {
		.phy_id = 0xffffffff,
		.phy_id_mask = 0xffffffff,
		.name = "Generic Clause 45 PHY",
		.read_status = genphy_c45_read_status,
		};

drivers/net/phy/phy_device.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -59,6 +59,13 @@ struct phy_fixup {
		int (run)(struct phy_device phydev);
		};

		static struct phy_driver genphy_c45_driver = {
		.phy_id = 0xffffffff,
		.phy_id_mask = 0xffffffff,
		.name = "Generic Clause 45 PHY",
		.read_status = genphy_c45_read_status,
		};

		__ETHTOOL_DECLARE_LINK_MODE_MASK(phy_basic_features) __ro_after_init;
		EXPORT_SYMBOL_GPL(phy_basic_features);

include/linux/phy.h

+0 −3

Original line number	Diff line number	Diff line
		@@ -1941,9 +1941,6 @@ int genphy_c45_ethtool_set_eee(struct phy_device *phydev,
		struct ethtool_keee *data);
		int genphy_c45_an_config_eee_aneg(struct phy_device *phydev);

		/* Generic C45 PHY driver */
		extern struct phy_driver genphy_c45_driver;

		/* The gen10g_* functions are the old Clause 45 stub */
		int gen10g_config_aneg(struct phy_device *phydev);