Commit 00f3a411 authored by Dan Carpenter's avatar Dan Carpenter Committed by Takashi Iwai
Browse files

ALSA: oxfw: remove an unnecessary condition in hwdep_read() 



Smatch complains that "count" isn't clamped properly and
"oxfw->dev_lock_changed" is false then it leads to an information
leak.  But it turns out that "oxfw->dev_lock_changed" is always
set and the condition can be removed.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/YA6ntkBxT/4DJ4YK@mwanda


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 62c2b4be

sound/firewire/oxfw/oxfw-hwdep.c

+4 −6
Original line number Diff line number Diff line
@@ -35,13 +35,11 @@ static long hwdep_read(struct snd_hwdep *hwdep, char __user *buf, long count, 
	}



	memset(&event, 0, sizeof(event));

	if (oxfw->dev_lock_changed) {

	event.lock_status.type = SNDRV_FIREWIRE_EVENT_LOCK_STATUS;

	event.lock_status.status = (oxfw->dev_lock_count > 0);

	oxfw->dev_lock_changed = false;



	count = min_t(long, count, sizeof(event.lock_status));

	}



	spin_unlock_irq(&oxfw->lock);