Commit 01e11d18 authored by Dan Carpenter's avatar Dan Carpenter Committed by Rafael J. Wysocki
Browse files

ACPI: SBS: Fix present test in acpi_battery_read() 



The battery->present variable is a 1 bit bitfield in a u8.  This means
that the "state & (1 << battery->id)" test will only work when
"battery->id" is zero, otherwise ->present is zero.  Fix this by adding
a !!.

Fixes: db1c291a ("ACPI: SBS: Make SBS reads table-driven.")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/aQSzr4NynN2mpEvG@stanley.mountain


Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 6146a0f1

drivers/acpi/sbs.c

+1 −1
Original line number Diff line number Diff line
@@ -487,7 +487,7 @@ static int acpi_battery_read(struct acpi_battery *battery) 
		if (result)

			return result;



		battery->present = state & (1 << battery->id);

		battery->present = !!(state & (1 << battery->id));

		if (!battery->present)

			return 0;