Commit 027a7a9c authored by Zhang Yi's avatar Zhang Yi Committed by Jens Axboe
Browse files

drbd: init queue_limits->max_hw_wzeroes_unmap_sectors parameter 



The parameter max_hw_wzeroes_unmap_sectors in queue_limits should be
equal to max_write_zeroes_sectors if it is set to a non-zero value.
However, when the backend bdev is specified, this parameter is
initialized to UINT_MAX during the call to blk_set_stacking_limits(),
while only max_write_zeroes_sectors is adjusted. Therefore, this
discrepancy triggers a value check failure in blk_validate_limits().

Since the drvd driver doesn't yet support unmap write zeroes, so fix
this failure by explicitly setting max_hw_wzeroes_unmap_sectors to
zero.

Fixes: 0c40d7cb ("block: introduce max_{hw|user}_wzeroes_unmap_sectors to queue limits")
Signed-off-by: default avatarZhang Yi <yi.zhang@huawei.com>
Reviewed-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: default avatarYu Kuai <yukuai3@huawei.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent de09bcb8

drivers/block/drbd/drbd_nl.c

+1 −0
Original line number Diff line number Diff line
@@ -1330,6 +1330,7 @@ void drbd_reconsider_queue_parameters(struct drbd_device *device, 
		lim.max_write_zeroes_sectors = DRBD_MAX_BBIO_SECTORS;

	else

		lim.max_write_zeroes_sectors = 0;

	lim.max_hw_wzeroes_unmap_sectors = 0;



	if ((lim.discard_granularity >> SECTOR_SHIFT) >

	    lim.max_hw_discard_sectors) {