Commit 02cd2d3b authored by Claudiu Beznea's avatar Claudiu Beznea Committed by Geert Uytterhoeven
Browse files

pinctrl: renesas: rzg2l: Configure the interrupt type on resume 



Commit dce0919c ("irqchip/renesas-rzg2l: Do not set TIEN and TINT
source at the same time") removed the setup of TINT from
rzg2l_irqc_irq_enable().  To address the spurious interrupt issue the
setup of TINT has been moved in rzg2l_tint_set_edge() through
rzg2l_disable_tint_and_set_tint_source().  With this, the interrupts are
not properly re-configured after a suspend-to-RAM cycle.  To address
this issue and avoid spurious interrupts while resumming set the
interrupt type before enabling it.

Fixes: dce0919c ("irqchip/renesas-rzg2l: Do not set TIEN and TINT source at the same time")
Signed-off-by: default avatarClaudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20240419063822.3467424-1-claudiu.beznea.uj@bp.renesas.com


Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
parent aa43c15a

drivers/pinctrl/renesas/pinctrl-rzg2l.c

+13 −10
Original line number Diff line number Diff line
@@ -2045,7 +2045,9 @@ static void rzg2l_gpio_irq_restore(struct rzg2l_pinctrl *pctrl) 


	for (unsigned int i = 0; i < RZG2L_TINT_MAX_INTERRUPT; i++) {

		struct irq_data *data;

		unsigned long flags;

		unsigned int virq;

		int ret;



		if (!pctrl->hwirq[i])

			continue;
@@ -2063,17 +2065,18 @@ static void rzg2l_gpio_irq_restore(struct rzg2l_pinctrl *pctrl) 
			continue;

		}



		if (!irqd_irq_disabled(data)) {

			unsigned long flags;



		/*

		 * This has to be atomically executed to protect against a concurrent

		 * interrupt.

		 */

		raw_spin_lock_irqsave(&pctrl->lock.rlock, flags);

		ret = rzg2l_gpio_irq_set_type(data, irqd_get_trigger_type(data));

		if (!ret && !irqd_irq_disabled(data))

			rzg2l_gpio_irq_enable(data);

		raw_spin_unlock_irqrestore(&pctrl->lock.rlock, flags);

		}



		if (ret)

			dev_crit(pctrl->dev, "Failed to set IRQ type for virq=%u\n", virq);

	}

}