Commit 0336f898 authored by Kees Cook's avatar Kees Cook
Browse files

coccinelle: Add rules to find str_down_up() replacements 



As done with str_up_down(), add checks for str_down_up() opportunities.
5 cases currently exist in the tree.

Suggested-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20240812183637.work.999-kees@kernel.org


Reviewed-by: default avatarAndy Shevchenko <andy@kernel.org>
Signed-off-by: default avatarKees Cook <kees@kernel.org>
parent f5c1ca3a

scripts/coccinelle/api/string_choices.cocci

+23 −0
Original line number Diff line number Diff line
@@ -62,3 +62,26 @@ e << str_up_down_r.E; 
@@



coccilib.report.print_report(p[0], "opportunity for str_up_down(%s)" % e)



@str_down_up depends on patch@

expression E;

@@

(

-      ((E) ? "down" : "up")

+      str_down_up(E)

)



@str_down_up_r depends on !patch exists@

expression E;

position P;

@@

(

*      ((E@P) ? "down" : "up")

)



@script:python depends on report@

p << str_down_up_r.P;

e << str_down_up_r.E;

@@



coccilib.report.print_report(p[0], "opportunity for str_down_up(%s)" % e)