Unverified Commit 042c48b7 authored Jan 22, 2025 by Lucas De Marchi Committed by Rodrigo Vivi Feb 03, 2025

drm/xe/devcoredump: Move exec queue snapshot to Contexts section



Having the exec queue snapshot inside a "GuC CT" section was always
wrong.  Commit c28fd6c3 ("drm/xe/devcoredump: Improve section
headings and add tile info") tried to fix that bug, but with that also
broke the mesa tool that parses the devcoredump, hence it was reverted
in commit a53da2fb ("drm/xe: Revert some changes that break a mesa
debug tool").

With the mesa tool also fixed, this can propagate as a fix on both
kernel and userspace side to avoid unnecessary headache for a debug
feature.

Cc: John Harrison <John.C.Harrison@Intel.com>
Cc: Julia Filipchuk <julia.filipchuk@intel.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: stable@vger.kernel.org
Fixes: a53da2fb ("drm/xe: Revert some changes that break a mesa debug tool")
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250123051112.1938193-2-lucas.demarchi@intel.com


Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
(cherry picked from commit a37934ea)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

parent 990d35ed

drivers/gpu/drm/xe/xe_devcoredump.c

+1 −5

Original line number	Diff line number	Diff line
		@@ -119,11 +119,7 @@ static ssize_t __xe_devcoredump_read(char *buffer, size_t count,
		drm_puts(&p, "\n** GuC CT **\n");
		xe_guc_ct_snapshot_print(ss->guc.ct, &p);

		/*
		* Don't add a new section header here because the mesa debug decoder
		* tool expects the context information to be in the 'GuC CT' section.
		*/
		/* drm_puts(&p, "\n** Contexts *\n"); /
		drm_puts(&p, "\n** Contexts **\n");
		xe_guc_exec_queue_snapshot_print(ss->ge, &p);

		drm_puts(&p, "\n** Job **\n");