Commit 0508316b authored by Joe Hattori's avatar Joe Hattori Committed by Lee Jones
Browse files

leds: netxbig: Fix an OF node reference leak in netxbig_leds_get_of_pdata() 



netxbig_leds_get_of_pdata() does not release the OF node obtained by
of_parse_phandle() when of_find_device_by_node() fails. Add an
of_node_put() call to fix the leak.

This bug was found by an experimental static analysis tool that I am
developing.

Fixes: 9af512e8 ("leds: netxbig: Convert to use GPIO descriptors")
Signed-off-by: default avatarJoe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Link: https://lore.kernel.org/r/20241216074923.628509-1-joe@pf.is.s.u-tokyo.ac.jp


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent 1c896113

drivers/leds/leds-netxbig.c

+1 −0
Original line number Diff line number Diff line
@@ -439,6 +439,7 @@ static int netxbig_leds_get_of_pdata(struct device *dev, 
	}

	gpio_ext_pdev = of_find_device_by_node(gpio_ext_np);

	if (!gpio_ext_pdev) {

		of_node_put(gpio_ext_np);

		dev_err(dev, "Failed to find platform device for gpio-ext\n");

		return -ENODEV;

	}