Commit 054e1c0e authored by Haiyue Wang's avatar Haiyue Wang Committed by Greg Kroah-Hartman
Browse files

uio: pci_sva: correct '-ENODEV' check logic 



The current '-ENODEV' check uses '&&', which can lead to a NULL pointer
dereference when udev is NULL.

Fix the condition to return -ENODEV if either udev or its pdev is NULL.

Fixes: 3397c3cd ("uio: Add SVA support for PCI devices via uio_pci_generic_sva.c")
Signed-off-by: default avatarHaiyue Wang <haiyuewa@163.com>
Link: https://patch.msgid.link/20260109175448.34309-1-haiyuewa@163.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 26c08dab

drivers/uio/uio_pci_generic_sva.c

+2 −2
Original line number Diff line number Diff line
@@ -29,7 +29,7 @@ static int uio_pci_sva_open(struct uio_info *info, struct inode *inode) 
	struct uio_pci_sva_dev *udev = info->priv;

	struct iommu_domain *domain;



	if (!udev && !udev->pdev)

	if (!udev || !udev->pdev)

		return -ENODEV;



	domain = iommu_get_domain_for_dev(&udev->pdev->dev);
@@ -51,7 +51,7 @@ static int uio_pci_sva_release(struct uio_info *info, struct inode *inode) 
{

	struct uio_pci_sva_dev *udev = info->priv;



	if (!udev && !udev->pdev)

	if (!udev || !udev->pdev)

		return -ENODEV;



	iommu_sva_unbind_device(udev->sva_handle);