Commit 05a9896f authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Greg Kroah-Hartman
Browse files

pcmcia: cistpl: Constify 'struct bin_attribute' 



The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.

Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/r/20241215-sysfs-const-bin_attr-pcmcia-v1-1-ebb82e47d834@weissschuh.net


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ae7a15fb

drivers/pcmcia/cistpl.c

+4 −4
Original line number Diff line number Diff line
@@ -1540,7 +1540,7 @@ static ssize_t pccard_extract_cis(struct pcmcia_socket *s, char *buf, 




static ssize_t pccard_show_cis(struct file *filp, struct kobject *kobj,

			       struct bin_attribute *bin_attr,

			       const struct bin_attribute *bin_attr,

			       char *buf, loff_t off, size_t count)

{

	unsigned int size = 0x200;
@@ -1571,7 +1571,7 @@ static ssize_t pccard_show_cis(struct file *filp, struct kobject *kobj, 




static ssize_t pccard_store_cis(struct file *filp, struct kobject *kobj,

				struct bin_attribute *bin_attr,

				const struct bin_attribute *bin_attr,

				char *buf, loff_t off, size_t count)

{

	struct pcmcia_socket *s;
@@ -1605,6 +1605,6 @@ static ssize_t pccard_store_cis(struct file *filp, struct kobject *kobj, 
const struct bin_attribute pccard_cis_attr = {

	.attr = { .name = "cis", .mode = S_IRUGO | S_IWUSR },

	.size = 0x200,

	.read = pccard_show_cis,

	.write = pccard_store_cis,

	.read_new = pccard_show_cis,

	.write_new = pccard_store_cis,

};