Commit 06ab64a0 authored by Philipp Stanner's avatar Philipp Stanner Committed by Dave Airlie
Browse files

drm: vmwgfx_surface.c: copy user-array safely 



Currently, there is no overflow-check with memdup_user().

Use the new function memdup_array_user() instead of memdup_user() for
duplicating the user-space array safely.

Suggested-by: default avatarDavid Airlie <airlied@redhat.com>
Signed-off-by: default avatarPhilipp Stanner <pstanner@redhat.com>
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Reviewed-by: default avatarZack Rusin <zackr@vmware.com>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230920123612.16914-7-pstanner@redhat.com
parent f37d63e2

drivers/gpu/drm/vmwgfx/vmwgfx_surface.c

+2 −2
Original line number Diff line number Diff line
@@ -777,9 +777,9 @@ int vmw_surface_define_ioctl(struct drm_device *dev, void *data, 
	       sizeof(metadata->mip_levels));

	metadata->num_sizes = num_sizes;

	metadata->sizes =

		memdup_user((struct drm_vmw_size __user *)(unsigned long)

		memdup_array_user((struct drm_vmw_size __user *)(unsigned long)

			    req->size_addr,

			    sizeof(*metadata->sizes) * metadata->num_sizes);

			    metadata->num_sizes, sizeof(*metadata->sizes));

	if (IS_ERR(metadata->sizes)) {

		ret = PTR_ERR(metadata->sizes);

		goto out_no_sizes;