Commit 06b9e914 authored by Kemeng Shi's avatar Kemeng Shi Committed by Theodore Ts'o
Browse files

jbd2: remove unused transaction->t_private_list 



After we remove ext4 journal callback, transaction->t_private_list is
not used anymore. Just remove unused transaction->t_private_list.

Signed-off-by: default avatarKemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: default avatarZhang Yi <yi.zhang@huawei.com>
Link: https://patch.msgid.link/20241218145414.1422946-3-shikemeng@huaweicloud.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent fa1008e3

Documentation/filesystems/journalling.rst

+1 −3
Original line number Diff line number Diff line
@@ -111,9 +111,7 @@ a callback function when the transaction is finally committed to disk, 
so that you can do some of your own management. You ask the journalling

layer for calling the callback by simply setting

``journal->j_commit_callback`` function pointer and that function is

called after each transaction commit. You can also use

``transaction->t_private_list`` for attaching entries to a transaction

that need processing when the transaction commits.

called after each transaction commit.



JBD2 also provides a way to block all transaction updates via

jbd2_journal_lock_updates() /

fs/jbd2/transaction.c

+0 −1
Original line number Diff line number Diff line
@@ -92,7 +92,6 @@ static void jbd2_get_transaction(journal_t *journal, 
	atomic_set(&transaction->t_outstanding_revokes, 0);

	atomic_set(&transaction->t_handle_count, 0);

	INIT_LIST_HEAD(&transaction->t_inode_list);

	INIT_LIST_HEAD(&transaction->t_private_list);



	/* Set up the commit timer for the new transaction. */

	journal->j_commit_timer.expires = round_jiffies_up(transaction->t_expires);

include/linux/jbd2.h

+0 −6
Original line number Diff line number Diff line
@@ -700,12 +700,6 @@ struct transaction_s 


	/* Disk flush needs to be sent to fs partition [no locking] */

	int			t_need_data_flush;



	/*

	 * For use by the filesystem to store fs-specific data

	 * structures associated with the transaction

	 */

	struct list_head	t_private_list;

};



struct transaction_run_stats_s {