Unverified Commit 072ce917 authored by Stefan Wahren's avatar Stefan Wahren Committed by Stephen Boyd
Browse files

clk: bcm: rpi: Add missing logs if firmware fails 



In contrary to raspberrypi_fw_set_rate(), the ops for is_prepared() and
recalc_rate() silently ignore firmware errors by just returning 0.
Since these operations should never fail, add at least error logs
to inform the user.

Signed-off-by: default avatarStefan Wahren <wahrenst@gmx.net>
Signed-off-by: default avatarMaíra Canal <mcanal@igalia.com>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent 8f5ae30d

drivers/clk/bcm/clk-raspberrypi.c

+8 −2
Original line number Diff line number Diff line
@@ -194,8 +194,11 @@ static int raspberrypi_fw_is_prepared(struct clk_hw *hw) 


	ret = raspberrypi_clock_property(rpi->firmware, data,

					 RPI_FIRMWARE_GET_CLOCK_STATE, &val);

	if (ret)

	if (ret) {

		dev_err_ratelimited(rpi->dev, "Failed to get %s state: %d\n",

				    clk_hw_get_name(hw), ret);

		return 0;

	}



	return !!(val & RPI_FIRMWARE_STATE_ENABLE_BIT);

}
@@ -211,8 +214,11 @@ static unsigned long raspberrypi_fw_get_rate(struct clk_hw *hw, 


	ret = raspberrypi_clock_property(rpi->firmware, data,

					 RPI_FIRMWARE_GET_CLOCK_RATE, &val);

	if (ret)

	if (ret) {

		dev_err_ratelimited(rpi->dev, "Failed to get %s frequency: %d\n",

				    clk_hw_get_name(hw), ret);

		return 0;

	}



	return val;

}