Commit 089768df authored by Yajun Deng's avatar Yajun Deng Committed by Ingo Molnar
Browse files

sched/rt: Change the type of 'sysctl_sched_rt_period' from 'unsigned int' to 'int' 



Doing this matches the natural type of 'int' based calculus
in sched_rt_handler(), and also enables the adding in of a
correct upper bounds check on the sysctl interface.

[ mingo: Rewrote the changelog. ]

Signed-off-by: default avatarYajun Deng <yajun.deng@linux.dev>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20231008021538.3063250-1-yajun.deng@linux.dev
parent f4bb5705

kernel/sched/rt.c

+3 −3
Original line number Diff line number Diff line
@@ -16,7 +16,7 @@ struct rt_bandwidth def_rt_bandwidth; 
 * period over which we measure -rt task CPU usage in us.

 * default: 1s

 */

unsigned int sysctl_sched_rt_period = 1000000;

int sysctl_sched_rt_period = 1000000;



/*

 * part of the period that we allow rt tasks to run in us.
@@ -34,7 +34,7 @@ static struct ctl_table sched_rt_sysctls[] = { 
	{

		.procname       = "sched_rt_period_us",

		.data           = &sysctl_sched_rt_period,

		.maxlen         = sizeof(unsigned int),

		.maxlen         = sizeof(int),

		.mode           = 0644,

		.proc_handler   = sched_rt_handler,

		.extra1         = SYSCTL_ONE,
@@ -47,7 +47,7 @@ static struct ctl_table sched_rt_sysctls[] = { 
		.mode           = 0644,

		.proc_handler   = sched_rt_handler,

		.extra1         = SYSCTL_NEG_ONE,

		.extra2         = SYSCTL_INT_MAX,

		.extra2         = (void *)&sysctl_sched_rt_period,

	},

	{

		.procname       = "sched_rr_timeslice_ms",

kernel/sched/sched.h

+1 −1
Original line number Diff line number Diff line
@@ -105,7 +105,7 @@ extern long calc_load_fold_active(struct rq *this_rq, long adjust); 


extern void call_trace_sched_update_nr_running(struct rq *rq, int count);



extern unsigned int sysctl_sched_rt_period;

extern int sysctl_sched_rt_period;

extern int sysctl_sched_rt_runtime;

extern int sched_rr_timeslice;