Commit 09057ce3 authored by Roger Quadros's avatar Roger Quadros Committed by David S. Miller
Browse files

net: ethernet: ti: am65-cpsw: use return instead of goto in am65_cpsw_run_xdp() 



In am65_cpsw_run_xdp() instead of goto followed by return, simply return.

Signed-off-by: default avatarRoger Quadros <rogerq@kernel.org>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1ae26bf6

drivers/net/ethernet/ti/am65-cpsw-nuss.c

+3 −7
Original line number Diff line number Diff line
@@ -1193,8 +1193,7 @@ static int am65_cpsw_run_xdp(struct am65_cpsw_rx_flow *flow, 


	switch (act) {

	case XDP_PASS:

		ret = AM65_CPSW_XDP_PASS;

		goto out;

		return AM65_CPSW_XDP_PASS;

	case XDP_TX:

		tx_chn = &common->tx_chns[cpu % AM65_CPSW_MAX_QUEUES];

		netif_txq = netdev_get_tx_queue(ndev, tx_chn->id);
@@ -1213,15 +1212,13 @@ static int am65_cpsw_run_xdp(struct am65_cpsw_rx_flow *flow, 
			goto drop;



		dev_sw_netstats_rx_add(ndev, pkt_len);

		ret = AM65_CPSW_XDP_CONSUMED;

		goto out;

		return AM65_CPSW_XDP_CONSUMED;

	case XDP_REDIRECT:

		if (unlikely(xdp_do_redirect(ndev, xdp, prog)))

			goto drop;



		dev_sw_netstats_rx_add(ndev, pkt_len);

		ret = AM65_CPSW_XDP_REDIRECT;

		goto out;

		return AM65_CPSW_XDP_REDIRECT;

	default:

		bpf_warn_invalid_xdp_action(ndev, prog, act);

		fallthrough;
@@ -1236,7 +1233,6 @@ static int am65_cpsw_run_xdp(struct am65_cpsw_rx_flow *flow, 
	page = virt_to_head_page(xdp->data);

	am65_cpsw_put_page(flow, page, true);



out:

	return ret;

}