Commit 0945a7b4 authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Jakub Kicinski
Browse files

net: dsa: ksz: remove setting of tx_lpi parameters 



dsa_user_get_eee() calls the DSA switch get_mac_eee() method followed
by phylink_ethtool_get_eee(), which goes on to call
phy_ethtool_get_eee(). This overwrites all members of the passed
ethtool_keee, which means anything written by the DSA switch
get_mac_eee() method will be discarded.

Remove setting any members in ksz_get_mac_eee().

Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1tUlkp-007UyW-OR@rmk-PC.armlinux.org.uk


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent aca14bbc

drivers/net/dsa/microchip/ksz_common.c

+0 −8
Original line number Diff line number Diff line
@@ -3492,14 +3492,6 @@ static bool ksz_support_eee(struct dsa_switch *ds, int port) 
static int ksz_get_mac_eee(struct dsa_switch *ds, int port,

			   struct ethtool_keee *e)

{

	/* There is no documented control of Tx LPI configuration. */

	e->tx_lpi_enabled = true;



	/* There is no documented control of Tx LPI timer. According to tests

	 * Tx LPI timer seems to be set by default to minimal value.

	 */

	e->tx_lpi_timer = 0;



	return 0;

}