Commit 09472cec authored by Johan Hovold's avatar Johan Hovold Committed by Wolfram Sang
Browse files

i2c: tiny-usb: drop redundant device reference 



Driver core holds a reference to the USB interface and its parent USB
device while the interface is bound to a driver and there is no need to
take additional references unless the structures are needed after
disconnect.

Drop the redundant device reference to reduce cargo culting, make it
easier to spot drivers where an extra reference is needed, and reduce
the risk of memory leaks when drivers fail to release it.

Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
parent 32dbfb4d

drivers/i2c/busses/i2c-tiny-usb.c

+3 −10
Original line number Diff line number Diff line
@@ -213,12 +213,6 @@ static int usb_write(struct i2c_adapter *adapter, int cmd, 
	return ret;

}



static void i2c_tiny_usb_free(struct i2c_tiny_usb *dev)

{

	usb_put_dev(dev->usb_dev);

	kfree(dev);

}



static int i2c_tiny_usb_probe(struct usb_interface *interface,

			      const struct usb_device_id *id)

{
@@ -237,7 +231,7 @@ static int i2c_tiny_usb_probe(struct usb_interface *interface, 
	if (!dev)

		goto error;



	dev->usb_dev = usb_get_dev(interface_to_usbdev(interface));

	dev->usb_dev = interface_to_usbdev(interface);

	dev->interface = interface;



	/* save our data pointer in this interface device */
@@ -277,8 +271,7 @@ static int i2c_tiny_usb_probe(struct usb_interface *interface, 
	return 0;



 error:

	if (dev)

		i2c_tiny_usb_free(dev);

	kfree(dev);



	return retval;

}
@@ -289,7 +282,7 @@ static void i2c_tiny_usb_disconnect(struct usb_interface *interface) 


	i2c_del_adapter(&dev->adapter);

	usb_set_intfdata(interface, NULL);

	i2c_tiny_usb_free(dev);

	kfree(dev);



	dev_dbg(&interface->dev, "disconnected\n");

}