Commit 098d8374 authored by Johan Hovold's avatar Johan Hovold Committed by Manivannan Sadhasivam
Browse files

bus: mhi: host: pci_generic: fix MHI BAR mapping 



A recent change converting the MHI pci_generic driver to use
pcim_iomap_region() failed to update the BAR parameter which is an index
rather than a mask.

This specifically broke the modem on machines like the Lenovo ThinkPad
X13s and x1e80100 CRD:

	mhi-pci-generic 0004:01:00.0: failed to map pci region: -22
	mhi-pci-generic 0004:01:00.0: probe with driver mhi-pci-generic failed with error -22

Fixes: bd23e836 ("bus: mhi: host: pci_generic: Use pcim_iomap_region() to request and map MHI BAR")
Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Mayank Rana <quic_mrana@quicinc.com>
Link: https://lore.kernel.org/r/20241201171120.31616-1-johan+linaro@kernel.org
parent 40384c84

drivers/bus/mhi/host/pci_generic.c

+1 −1
Original line number Diff line number Diff line
@@ -917,7 +917,7 @@ static int mhi_pci_claim(struct mhi_controller *mhi_cntrl, 
		return err;

	}



	mhi_cntrl->regs = pcim_iomap_region(pdev, 1 << bar_num, pci_name(pdev));

	mhi_cntrl->regs = pcim_iomap_region(pdev, bar_num, pci_name(pdev));

	if (IS_ERR(mhi_cntrl->regs)) {

		err = PTR_ERR(mhi_cntrl->regs);

		dev_err(&pdev->dev, "failed to map pci region: %d\n", err);