Commit 0a470c84 authored by Yang Li's avatar Yang Li Committed by Bjorn Helgaas
Browse files

x86/pci: Return true/false (not 1/0) from bool functions 

Return boolean values ("true" or "false") instead of 1 or 0 from bool
functions.  This fixes the following warnings from coccicheck:

  ./arch/x86/pci/mmconfig-shared.c:464:9-10: WARNING: return of 0/1 in function 'is_mmconf_reserved' with return type bool
  ./arch/x86/pci/mmconfig-shared.c:493:5-6: WARNING: return of 0/1 in function 'is_mmconf_reserved' with return type bool
  ./arch/x86/pci/mmconfig-shared.c:501:9-10: WARNING: return of 0/1 in function 'is_mmconf_reserved' with return type bool
  ./arch/x86/pci/mmconfig-shared.c:522:5-6: WARNING: return of 0/1 in function 'is_mmconf_reserved' with return type bool

Link: https://lore.kernel.org/r/1615794000-102771-1-git-send-email-yang.lee@linux.alibaba.com


Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarKrzysztof Wilczyński <kw@linux.com>
parent 6efb943b

arch/x86/pci/mmconfig-shared.c

+5 −5
Original line number Diff line number Diff line
@@ -461,7 +461,7 @@ static bool __ref is_mmconf_reserved(check_reserved_t is_reserved, 
	}



	if (size < (16UL<<20) && size != old_size)

		return 0;

		return false;



	if (dev)

		dev_info(dev, "MMCONFIG at %pR reserved in %s\n",
@@ -493,7 +493,7 @@ static bool __ref is_mmconf_reserved(check_reserved_t is_reserved, 
				&cfg->res, (unsigned long) cfg->address);

	}



	return 1;

	return true;

}



static bool __ref
@@ -501,7 +501,7 @@ pci_mmcfg_check_reserved(struct device *dev, struct pci_mmcfg_region *cfg, int e 
{

	if (!early && !acpi_disabled) {

		if (is_mmconf_reserved(is_acpi_reserved, cfg, dev, 0))

			return 1;

			return true;



		if (dev)

			dev_info(dev, FW_INFO
@@ -522,14 +522,14 @@ pci_mmcfg_check_reserved(struct device *dev, struct pci_mmcfg_region *cfg, int e 
	 * _CBA method, just assume it's reserved.

	 */

	if (pci_mmcfg_running_state)

		return 1;

		return true;



	/* Don't try to do this check unless configuration

	   type 1 is available. how about type 2 ?*/

	if (raw_pci_ops)

		return is_mmconf_reserved(e820__mapped_all, cfg, dev, 1);



	return 0;

	return false;

}



static void __init pci_mmcfg_reject_broken(int early)