Unverified Commit 0a59deb2 authored by Sui Jingfeng's avatar Sui Jingfeng Committed by Robert Foss
Browse files

drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: Remove a redundant check on... 


drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: Remove a redundant check on existence of bridge->encoder

In the ge_b850v3_lvds_create_connector function, the check on the existence
of bridge->encoder is not necessary, as it has already been checked in the
drm_bridge_attach() function called by upstream bridge or driver. Hence, it
is guaranteed that the .encoder member of the drm_bridge instance is not
NULL when cdns_mhdp_connector_init() function get called.

Remove the redundant checking codes "if (!bridge->encoder) { ... }".

Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarSui Jingfeng <sui.jingfeng@linux.dev>
Signed-off-by: default avatarRobert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240513153109.46786-9-sui.jingfeng@linux.dev
parent b24fd6e9

drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c

+0 −5
Original line number Diff line number Diff line
@@ -165,11 +165,6 @@ static int ge_b850v3_lvds_create_connector(struct drm_bridge *bridge) 
	struct drm_connector *connector = &ge_b850v3_lvds_ptr->connector;

	int ret;



	if (!bridge->encoder) {

		DRM_ERROR("Parent encoder object not found");

		return -ENODEV;

	}



	connector->polled = DRM_CONNECTOR_POLL_HPD;



	drm_connector_helper_add(connector,