Commit 0aa4523c authored by Advait Dhamorikar's avatar Advait Dhamorikar Committed by Vinod Koul
Browse files

dmaengine: ep93xx: Fix unsigned compared against 0 



An unsigned value can never be negative,
so this test will always evaluate the same way.
In ep93xx_dma_alloc_chan_resources: An unsigned dma_cfg.port's
value is checked against EP93XX_DMA_I2S1 which is 0.

Signed-off-by: default avatarAdvait Dhamorikar <advaitdhamorikar@gmail.com>
Link: https://lore.kernel.org/r/20241005093436.27728-1-advaitdhamorikar@gmail.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 662f0453

drivers/dma/ep93xx_dma.c

+1 −2
Original line number Diff line number Diff line
@@ -929,8 +929,7 @@ static int ep93xx_dma_alloc_chan_resources(struct dma_chan *chan) 


	/* Sanity check the channel parameters */

	if (!edmac->edma->m2m) {

		if (edmac->dma_cfg.port < EP93XX_DMA_I2S1 ||

		    edmac->dma_cfg.port > EP93XX_DMA_IRDA)

		if (edmac->dma_cfg.port > EP93XX_DMA_IRDA)

			return -EINVAL;

		if (edmac->dma_cfg.dir != ep93xx_dma_chan_direction(chan))

			return -EINVAL;