Commit 0abcac4f authored by Samasth Norway Ananda's avatar Samasth Norway Ananda Committed by Conor Dooley
Browse files

firmware: microchip: fix wrong sizeof argument 



response_msg is a pointer to an unsigned int (u32). So passing just
response_msg to sizeof would not print the size of the variable. To get
the size of response_msg we need to pass it as a pointer variable.

Fixes: ec5b0f11 ("firmware: microchip: add PolarFire SoC Auto Update support")
Signed-off-by: default avatarSamasth Norway Ananda <samasth.norway.ananda@oracle.com>
Signed-off-by: default avatarConor Dooley <conor.dooley@microchip.com>
parent 6613476e

drivers/firmware/microchip/mpfs-auto-update.c

+1 −1
Original line number Diff line number Diff line
@@ -167,7 +167,7 @@ static int mpfs_auto_update_verify_image(struct fw_upload *fw_uploader) 
	u32 *response_msg;

	int ret;



	response_msg = devm_kzalloc(priv->dev, AUTO_UPDATE_FEATURE_RESP_SIZE * sizeof(response_msg),

	response_msg = devm_kzalloc(priv->dev, AUTO_UPDATE_FEATURE_RESP_SIZE * sizeof(*response_msg),

				    GFP_KERNEL);

	if (!response_msg)

		return -ENOMEM;