Commit 0b1b4b04 authored by Hannes Reinecke's avatar Hannes Reinecke Committed by Martin K. Petersen
Browse files

scsi: pmcraid: Add missing scsi_device_put() in pmcraid_eh_target_reset_handler() 



When breaking out of an shost_for_each_device() loop one needs to do an
explicit scsi_device_put().

Fixes: c2a14ab3 ("scsi: pmcraid: Select device in pmcraid_eh_target_reset_handler()")
Signed-off-by: default avatarHannes Reinecke <hare@suse.de>
Link: https://lore.kernel.org/r/20231023072957.20191-1-hare@suse.de


Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 96f41cdd

drivers/scsi/pmcraid.c

+6 −3
Original line number Diff line number Diff line
@@ -3066,6 +3066,7 @@ static int pmcraid_eh_target_reset_handler(struct scsi_cmnd *scmd) 
{

	struct Scsi_Host *shost = scmd->device->host;

	struct scsi_device *scsi_dev = NULL, *tmp;

	int ret;



	shost_for_each_device(tmp, shost) {

		if ((tmp->channel == scmd->device->channel) &&
@@ -3078,9 +3079,11 @@ static int pmcraid_eh_target_reset_handler(struct scsi_cmnd *scmd) 
		return FAILED;

	sdev_printk(KERN_INFO, scsi_dev,

		    "Doing target reset due to an I/O command timeout.\n");

	return pmcraid_reset_device(scsi_dev,

	ret = pmcraid_reset_device(scsi_dev,

				   PMCRAID_INTERNAL_TIMEOUT,

				   RESET_DEVICE_TARGET);

	scsi_device_put(scsi_dev);

	return ret;

}



/**