Commit 0c2768bf authored by Lizhi Hou's avatar Lizhi Hou Committed by Mario Limonciello
Browse files

accel/amdxdna: Return error when setting clock failed for npu1 



Due to miss returning error when setting clock, the smatch static
checker reports warning:
  drivers/accel/amdxdna/aie2_smu.c:68 npu1_set_dpm()
  error: uninitialized symbol 'freq'.

Fixes: f4d7b8a6 ("accel/amdxdna: Enhance power management settings")
Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/dri-devel/202267d0-882e-4593-b58d-be9274592f9b@stanley.mountain/


Signed-off-by: default avatarLizhi Hou <lizhi.hou@amd.com>
Reviewed-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250109194811.499505-1-lizhi.hou@amd.com
parent 97395ce7

drivers/accel/amdxdna/aie2_smu.c

+2 −0
Original line number Diff line number Diff line
@@ -64,6 +64,7 @@ int npu1_set_dpm(struct amdxdna_dev_hdl *ndev, u32 dpm_level) 
	if (ret) {

		XDNA_ERR(ndev->xdna, "Set npu clock to %d failed, ret %d\n",

			 ndev->priv->dpm_clk_tbl[dpm_level].npuclk, ret);

		return ret;

	}

	ndev->npuclk_freq = freq;
@@ -72,6 +73,7 @@ int npu1_set_dpm(struct amdxdna_dev_hdl *ndev, u32 dpm_level) 
	if (ret) {

		XDNA_ERR(ndev->xdna, "Set h clock to %d failed, ret %d\n",

			 ndev->priv->dpm_clk_tbl[dpm_level].hclk, ret);

		return ret;

	}

	ndev->hclk_freq = freq;

	ndev->dpm_level = dpm_level;