Commit 0d0f1314 authored by Qu Wenruo's avatar Qu Wenruo Committed by David Sterba
Browse files

btrfs: zlib: fix the folio leak on S390 hardware acceleration 



[BUG]
After commit aa60fe12 ("btrfs: zlib: refactor S390x HW acceleration
buffer preparation"), we no longer release the folio of the page cache
of folio returned by btrfs_compress_filemap_get_folio() for S390
hardware acceleration path.

[CAUSE]
Before that commit, we call kumap_local() and folio_put() after handling
each folio.

Although the timing is not ideal (it release previous folio at the
beginning of the loop, and rely on some extra cleanup out of the loop),
it at least handles the folio release correctly.

Meanwhile the refactored code is easier to read, it lacks the call to
release the filemap folio.

[FIX]
Add the missing folio_put() for copy_data_into_buffer().

CC: linux-s390@vger.kernel.org # 6.18+
Fixes: aa60fe12 ("btrfs: zlib: refactor S390x HW acceleration buffer preparation")
Reviewed-by: default avatarBoris Burkov <boris@bur.io>
Signed-off-by: default avatarQu Wenruo <wqu@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 4e159150

fs/btrfs/zlib.c

+1 −0
Original line number Diff line number Diff line
@@ -139,6 +139,7 @@ static int copy_data_into_buffer(struct address_space *mapping, 
		data_in = kmap_local_folio(folio, offset);

		memcpy(workspace->buf + cur - filepos, data_in, copy_length);

		kunmap_local(data_in);

		folio_put(folio);

		cur += copy_length;

	}

	return 0;