Commit 0d7ed32c authored by David Sterba's avatar David Sterba
Browse files

btrfs: protect exclusive_operation by super_lock 



The exclusive operation is now atomically checked and set using bit
operations. Switch it to protection by spinlock. The super block lock is
not frequently used and adding a new lock seems like an overkill so it
should be safe to reuse it.

The reason to use spinlock is to enhance the locking context so more
checks can be done, eg. allowing the same exclusive operation enter
the exclop section and cancel the running one. This will be used for
resize and device delete.

Reviewed-by: default avatarJosef Bacik <josef@toxicpanda.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 24880be5

fs/btrfs/ctree.h

+2 −2
Original line number Diff line number Diff line
@@ -992,8 +992,8 @@ struct btrfs_fs_info { 
	 */

	int send_in_progress;



	/* Type of exclusive operation running */

	unsigned long exclusive_operation;

	/* Type of exclusive operation running, protected by super_lock */

	enum btrfs_exclusive_operation exclusive_operation;



	/*

	 * Zone size > 0 when in ZONED mode, otherwise it's used for a check

fs/btrfs/ioctl.c

+15 −1
Original line number Diff line number Diff line
@@ -353,15 +353,29 @@ int btrfs_fileattr_set(struct user_namespace *mnt_userns, 
	return ret;

}



/*

 * Start exclusive operation @type, return true on success

 */

bool btrfs_exclop_start(struct btrfs_fs_info *fs_info,

			enum btrfs_exclusive_operation type)

{

	return !cmpxchg(&fs_info->exclusive_operation, BTRFS_EXCLOP_NONE, type);

	bool ret = false;



	spin_lock(&fs_info->super_lock);

	if (fs_info->exclusive_operation == BTRFS_EXCLOP_NONE) {

		fs_info->exclusive_operation = type;

		ret = true;

	}

	spin_unlock(&fs_info->super_lock);



	return ret;

}



void btrfs_exclop_finish(struct btrfs_fs_info *fs_info)

{

	spin_lock(&fs_info->super_lock);

	WRITE_ONCE(fs_info->exclusive_operation, BTRFS_EXCLOP_NONE);

	spin_unlock(&fs_info->super_lock);

	sysfs_notify(&fs_info->fs_devices->fsid_kobj, NULL, "exclusive_operation");

}