Commit 0d9a60a0 authored by Pavan Chebbi's avatar Pavan Chebbi Committed by Jakub Kicinski
Browse files

bnxt_en: Fix RSS table size check when changing ethtool channels 



When changing channels, the current check in bnxt_set_channels()
is not checking for non-default RSS contexts when the RSS table size
changes. The current check for IFF_RXFH_CONFIGURED is only sufficient
for the default RSS context. Expand the check to include the presence
of any non-default RSS contexts.

Allowing such change will result in incorrect configuration of the
context's RSS table when the table size changes.

Fixes: b3d0083c ("bnxt_en: Support RSS contexts in ethtool .{get|set}_rxfh()")
Reported-by: default avatarBjörn Töpel <bjorn@kernel.org>
Link: https://lore.kernel.org/netdev/20260303181535.2671734-1-bjorn@kernel.org/


Reviewed-by: default avatarAndy Gospodarek <andrew.gospodarek@broadcom.com>
Signed-off-by: default avatarPavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Link: https://patch.msgid.link/20260306225854.3575672-1-michael.chan@broadcom.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 183f6825

drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

+2 −2
Original line number Diff line number Diff line
@@ -979,8 +979,8 @@ static int bnxt_set_channels(struct net_device *dev, 


	if (bnxt_get_nr_rss_ctxs(bp, req_rx_rings) !=

	    bnxt_get_nr_rss_ctxs(bp, bp->rx_nr_rings) &&

	    netif_is_rxfh_configured(dev)) {

		netdev_warn(dev, "RSS table size change required, RSS table entries must be default to proceed\n");

	    (netif_is_rxfh_configured(dev) || bp->num_rss_ctx)) {

		netdev_warn(dev, "RSS table size change required, RSS table entries must be default (with no additional RSS contexts present) to proceed\n");

		return -EINVAL;

	}