Commit 0df69324 authored by Donald Hunter's avatar Donald Hunter Committed by Jakub Kicinski
Browse files

tools: ynl: handle broken pipe gracefully in CLI 



When sending YNL CLI output into a pipe, closing the pipe causes a
BrokenPipeError. E.g. running the following and quitting less:

./tools/net/ynl/pyynl/cli.py --family rt-link --dump getlink | less
Traceback (most recent call last):
  File "/home/donaldh/net-next/./tools/net/ynl/pyynl/cli.py", line 160, in <module>
    main()
    ~~~~^^
  File "/home/donaldh/net-next/./tools/net/ynl/pyynl/cli.py", line 142, in main
    output(reply)
    ~~~~~~^^^^^^^
  File "/home/donaldh/net-next/./tools/net/ynl/pyynl/cli.py", line 97, in output
    pprint.PrettyPrinter().pprint(msg)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^
[...]
BrokenPipeError: [Errno 32] Broken pipe

Consolidate the try block for ops and notifications, and gracefully
handle the BrokenPipeError by adding an exception handler to the
consolidated try block.

Signed-off-by: default avatarDonald Hunter <donald.hunter@gmail.com>
Link: https://patch.msgid.link/20250508112102.63539-1-donald.hunter@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 1b2900db

tools/net/ynl/pyynl/cli.py

+8 −7
Original line number Diff line number Diff line
@@ -144,16 +144,17 @@ def main(): 
            ops = [ (item[0], json.loads(item[1]), args.flags or []) for item in args.multi ]

            reply = ynl.do_multi(ops)

            output(reply)

    except NlError as e:

        print(e)

        exit(1)



        if args.ntf:

        try:

            for msg in ynl.poll_ntf(duration=args.duration):

                output(msg)

    except NlError as e:

        print(e)

        exit(1)

    except KeyboardInterrupt:

        pass

    except BrokenPipeError:

        pass





if __name__ == "__main__":