Commit 0ea8176c authored by Gangliang Xie's avatar Gangliang Xie Committed by Alex Deucher
Browse files

drm/amd/pm: remove unnecessary prints for smu busy 



smu busy is a normal case when calling SMU_MSG_GetBadPageCount, so no need
to print error status at each time.Instead, only print error status when
timeout given by user is reached.

Signed-off-by: default avatarGangliang Xie <ganglxie@amd.com>
Reviewed-by: default avatarHawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 7fb41ab3

drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_12_ppt.c

+2 −0
Original line number Diff line number Diff line
@@ -956,6 +956,8 @@ static int smu_v13_0_12_get_badpage_count(struct amdgpu_device *adev, uint32_t * 
		now = (uint64_t)ktime_to_ms(ktime_get());

	} while (now < end);



	dev_err(adev->dev,

			 "smu get bad page count timeout!\n");

	return ret;

}

drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c

+7 −3
Original line number Diff line number Diff line
@@ -164,6 +164,10 @@ static void __smu_cmn_reg_print_error(struct smu_context *smu, 
				    msg_index, param, message);

		break;

	case SMU_RESP_BUSY_OTHER:

		/* It is normal for SMU_MSG_GetBadPageCount to return busy

		 * so don't print error at this case.

		 */

		if (msg != SMU_MSG_GetBadPageCount)

			dev_err_ratelimited(adev->dev,

						"SMU: I'm very busy for your command: index:%d param:0x%08X message:%s",

						msg_index, param, message);