Commit 0f601dec authored by Rajvi Jingar's avatar Rajvi Jingar Committed by Hans de Goede
Browse files

platform/x86/intel/pmc: Display LPM requirements for multiple PMCs 



Update the substate_requirements attribute to display the requirements for
all the PMCs on a package.

Signed-off-by: default avatarRajvi Jingar <rajvi.jingar@linux.intel.com>
Signed-off-by: default avatarDavid E. Box <david.e.box@linux.intel.com>
Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20231129222132.2331261-17-david.e.box@linux.intel.com


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 104f7494

drivers/platform/x86/intel/pmc/core.c

+68 −55
Original line number Diff line number Diff line
@@ -728,7 +728,7 @@ static int pmc_core_substate_l_sts_regs_show(struct seq_file *s, void *unused) 
}

DEFINE_SHOW_ATTRIBUTE(pmc_core_substate_l_sts_regs);



static void pmc_core_substate_req_header_show(struct seq_file *s)

static void pmc_core_substate_req_header_show(struct seq_file *s, int pmc_index)

{

	struct pmc_dev *pmcdev = s->private;

	int i, mode;
@@ -743,21 +743,38 @@ static void pmc_core_substate_req_header_show(struct seq_file *s) 
static int pmc_core_substate_req_regs_show(struct seq_file *s, void *unused)

{

	struct pmc_dev *pmcdev = s->private;

	struct pmc *pmc = pmcdev->pmcs[PMC_IDX_MAIN];

	const struct pmc_bit_map **maps = pmc->map->lpm_sts;

	const struct pmc_bit_map *map;

	const int num_maps = pmc->map->lpm_num_maps;

	u32 sts_offset = pmc->map->lpm_status_offset;

	u32 *lpm_req_regs = pmc->lpm_req_regs;

	int mp;

	u32 sts_offset;

	u32 *lpm_req_regs;

	int num_maps, mp, pmc_index;



	for (pmc_index = 0; pmc_index < ARRAY_SIZE(pmcdev->pmcs); ++pmc_index) {

		struct pmc *pmc = pmcdev->pmcs[pmc_index];

		const struct pmc_bit_map **maps;



		if (!pmc)

			continue;



		maps = pmc->map->lpm_sts;

		num_maps = pmc->map->lpm_num_maps;

		sts_offset = pmc->map->lpm_status_offset;

		lpm_req_regs = pmc->lpm_req_regs;



		/*

		 * When there are multiple PMCs, though the PMC may exist, the

		 * requirement register discovery could have failed so check

		 * before accessing.

		 */

		if (!lpm_req_regs)

			continue;



		/* Display the header */

	pmc_core_substate_req_header_show(s);

		pmc_core_substate_req_header_show(s, pmc_index);



		/* Loop over maps */

		for (mp = 0; mp < num_maps; mp++) {

			u32 req_mask = 0;

			u32 lpm_status;

			const struct pmc_bit_map *map;

			int mode, idx, i, len = 32;



			/*
@@ -776,35 +793,31 @@ static int pmc_core_substate_req_regs_show(struct seq_file *s, void *unused) 
			for (i = 0; map[i].name && i < len; i++) {

				u32 bit_mask = map[i].bit_mask;



			if (!(bit_mask & req_mask))

				if (!(bit_mask & req_mask)) {

					/*

					 * Not required for any enabled states

					 * so don't display

					 */

					continue;

				}



				/* Display the element name in the first column */

			seq_printf(s, "%30s |", map[i].name);

				seq_printf(s, "pmc%d: %26s |", pmc_index, map[i].name);



				/* Loop over the enabled states and display if required */

				pmc_for_each_mode(idx, mode, pmcdev) {

				if (lpm_req_regs[mp + (mode * num_maps)] & bit_mask)

					seq_printf(s, " %9s |",

						   "Required");

				else

					seq_printf(s, " %9s |", " ");

					bool required = lpm_req_regs[mp + (mode * num_maps)] &

							bit_mask;

					seq_printf(s, " %9s |", required ? "Required" : " ");

				}



				/* In Status column, show the last captured state of this agent */

			if (lpm_status & bit_mask)

				seq_printf(s, " %9s |", "Yes");

			else

				seq_printf(s, " %9s |", " ");

				seq_printf(s, " %9s |", lpm_status & bit_mask ? "Yes" : " ");



				seq_puts(s, "\n");

			}

		}



	}

	return 0;

}

DEFINE_SHOW_ATTRIBUTE(pmc_core_substate_req_regs);