Commit 1008368e authored by Matthew Auld's avatar Matthew Auld
Browse files

drm/xe/bb: assert width in xe_bb_create_job() 



The queue width will determine the number of batch buffer emitted into
the ring. In the case of xe_bb_create_job() we pass exactly one batch
address, therefore add an assert for the width to make sure we don't go
out of bounds. While here also convert to the helper to determine if the
queue is migration based.

Signed-off-by: default avatarMatthew Auld <matthew.auld@intel.com>
Cc: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: default avatarNirmoy Das <nirmoy.das@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240320112730.219854-3-matthew.auld@intel.com
parent 4c15a6dc

drivers/gpu/drm/xe/xe_bb.c

+2 −1
Original line number Diff line number Diff line
@@ -96,7 +96,8 @@ struct xe_sched_job *xe_bb_create_job(struct xe_exec_queue *q, 
{

	u64 addr = xe_sa_bo_gpu_addr(bb->bo);



	xe_gt_assert(q->gt, !(q->vm && q->vm->flags & XE_VM_FLAG_MIGRATION));

	xe_gt_assert(q->gt, !xe_sched_job_is_migration(q));

	xe_gt_assert(q->gt, q->width == 1);

	return __xe_bb_create_job(q, bb, &addr);

}