Commit 10166c23 authored by Joey Gouly's avatar Joey Gouly Committed by Will Deacon
Browse files

arm64: pkeys: remove redundant WARN 



FEAT_PAN3 is present if FEAT_S1POE is, this WARN() was to represent that.
However execute_only_pkey() is always called by mmap(), even on a CPU without
POE support.

Rather than making the WARN() conditional, just delete it.

Reported-by: default avatarNaresh Kamboju <naresh.kamboju@linaro.org>
Link: https://lore.kernel.org/linux-arm-kernel/CA+G9fYvarKEPN3u1Ogw2pcw4h6r3OMzg+5qJpYkAXRunAEF_0Q@mail.gmail.com/


Signed-off-by: default avatarJoey Gouly <joey.gouly@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Link: https://lore.kernel.org/r/20240910105004.706981-1-joey.gouly@arm.com


Signed-off-by: default avatarWill Deacon <will@kernel.org>
parent 6a428d63

arch/arm64/include/asm/pkeys.h

+0 −2
Original line number Diff line number Diff line
@@ -37,8 +37,6 @@ static inline int arch_override_mprotect_pkey(struct vm_area_struct *vma, 
static inline int execute_only_pkey(struct mm_struct *mm)

{

	// Execute-only mappings are handled by EPAN/FEAT_PAN3.

	WARN_ON_ONCE(!cpus_have_final_cap(ARM64_HAS_EPAN));



	return -1;

}