Unverified Commit 101e5c5c authored by Dan Carpenter's avatar Dan Carpenter Committed by Krzysztof Wilczyński
Browse files

PCI: qcom: Fix missing error code in qcom_pcie_probe() 

Return a negative error code if dev_pm_opp_find_freq_floor() fails;
don't return success.

Fixes: 78b5f6f8855e ("PCI: qcom: Add OPP support to scale performance")
Link: https://lore.kernel.org/linux-pci/20240708180539.1447307-2-dan.carpenter@linaro.org


Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Tested-by: default avatarAnders Roxell <anders.roxell@linaro.org>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
parent 5b6272e0

drivers/pci/controller/dwc/pcie-qcom.c

+2 −1
Original line number Diff line number Diff line
@@ -1578,7 +1578,8 @@ static int qcom_pcie_probe(struct platform_device *pdev) 
	if (!ret) {

		opp = dev_pm_opp_find_freq_floor(dev, &max_freq);

		if (IS_ERR(opp)) {

			dev_err_probe(pci->dev, PTR_ERR(opp),

			ret = PTR_ERR(opp);

			dev_err_probe(pci->dev, ret,

				      "Unable to find max freq OPP\n");

			goto err_pm_runtime_put;

		} else {