Commit 10720206 authored by Nam Cao's avatar Nam Cao Committed by Thomas Gleixner
Browse files

irqchip/sifive-plic: Fix frozen interrupt due to affinity setting 



PLIC ignores interrupt completion message for disabled interrupt, explained
by the specification:

    The PLIC signals it has completed executing an interrupt handler by
    writing the interrupt ID it received from the claim to the
    claim/complete register. The PLIC does not check whether the completion
    ID is the same as the last claim ID for that target. If the completion
    ID does not match an interrupt source that is currently enabled for
    the target, the completion is silently ignored.

This caused problems in the past, because an interrupt can be disabled
while still being handled and plic_irq_eoi() had no effect. That was fixed
by checking if the interrupt is disabled, and if so enable it, before
sending the completion message. That check is done with irqd_irq_disabled().

However, that is not sufficient because the enable bit for the handling
hart can be zero despite irqd_irq_disabled(d) being false. This can happen
when affinity setting is changed while a hart is still handling the
interrupt.

This problem is easily reproducible by dumping a large file to uart (which
generates lots of interrupts) and at the same time keep changing the uart
interrupt's affinity setting. The uart port becomes frozen almost
instantaneously.

Fix this by checking PLIC's enable bit instead of irqd_irq_disabled().

Fixes: cc9f04f9 ("irqchip/sifive-plic: Implement irq_set_affinity() for SMP host")
Signed-off-by: default avatarNam Cao <namcao@linutronix.de>
Signed-off-by: default avatarThomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/20260212114125.3148067-1-namcao@linutronix.de
parent 97029699

drivers/irqchip/irq-sifive-plic.c

+6 −1
Original line number Diff line number Diff line
@@ -172,8 +172,13 @@ static void plic_irq_disable(struct irq_data *d) 
static void plic_irq_eoi(struct irq_data *d)

{

	struct plic_handler *handler = this_cpu_ptr(&plic_handlers);

	u32 __iomem *reg;

	bool enabled;



	reg = handler->enable_base + (d->hwirq / 32) * sizeof(u32);

	enabled = readl(reg) & BIT(d->hwirq % 32);



	if (unlikely(irqd_irq_disabled(d))) {

	if (unlikely(!enabled)) {

		plic_toggle(handler, d->hwirq, 1);

		writel(d->hwirq, handler->hart_base + CONTEXT_CLAIM);

		plic_toggle(handler, d->hwirq, 0);