Commit 107d55ef authored by Muhammad Qasim Abdul Majeed's avatar Muhammad Qasim Abdul Majeed Committed by Rafael J. Wysocki
Browse files

ACPI: scan: Use strscpy() instead of strcpy() 

Replace strcpy() with strscpy() in the ACPI device enumeration code.

strcpy() has been deprecated because it is generally unsafe, so it
is better to eliminate it from the kernel source.

Link: https://github.com/KSPP/linux/issues/88


Signed-off-by: default avatarMuhammad Qasim Abdul Majeed <qasim.majeed20@gmail.com>
Link: https://patch.msgid.link/20240915183822.34588-9-qasim.majeed20@gmail.com


[ rjw: Subject and changelog edits ]
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 0dac2f74

drivers/acpi/scan.c

+7 −7
Original line number Diff line number Diff line
@@ -1179,19 +1179,19 @@ static void acpi_device_get_busid(struct acpi_device *device) 
	 * TBD: Shouldn't this value be unique (within the ACPI namespace)?

	 */

	if (!acpi_dev_parent(device)) {

		strcpy(device->pnp.bus_id, "ACPI");

		strscpy(device->pnp.bus_id, "ACPI");

		return;

	}



	switch (device->device_type) {

	case ACPI_BUS_TYPE_POWER_BUTTON:

		strcpy(device->pnp.bus_id, "PWRF");

		strscpy(device->pnp.bus_id, "PWRF");

		break;

	case ACPI_BUS_TYPE_SLEEP_BUTTON:

		strcpy(device->pnp.bus_id, "SLPF");

		strscpy(device->pnp.bus_id, "SLPF");

		break;

	case ACPI_BUS_TYPE_ECDT_EC:

		strcpy(device->pnp.bus_id, "ECDT");

		strscpy(device->pnp.bus_id, "ECDT");

		break;

	default:

		acpi_get_name(device->handle, ACPI_SINGLE_NAME, &buffer);
@@ -1202,7 +1202,7 @@ static void acpi_device_get_busid(struct acpi_device *device) 
			else

				break;

		}

		strcpy(device->pnp.bus_id, bus_id);

		strscpy(device->pnp.bus_id, bus_id);

		break;

	}

}
@@ -1453,8 +1453,8 @@ static void acpi_set_pnp_ids(acpi_handle handle, struct acpi_device_pnp *pnp, 
			 acpi_object_is_system_bus(handle)) {

			/* \_SB, \_TZ, LNXSYBUS */

			acpi_add_id(pnp, ACPI_BUS_HID);

			strcpy(pnp->device_name, ACPI_BUS_DEVICE_NAME);

			strcpy(pnp->device_class, ACPI_BUS_CLASS);

			strscpy(pnp->device_name, ACPI_BUS_DEVICE_NAME);

			strscpy(pnp->device_class, ACPI_BUS_CLASS);

		}



		break;