Commit 10ba628e authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Dmitry Torokhov
Browse files

Input: melfas_mip4 - simplify with dev_err_probe() 



Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20230625162817.100397-15-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent bf2ae389

drivers/input/touchscreen/melfas_mip4.c

+2 −7
Original line number Diff line number Diff line
@@ -1451,13 +1451,8 @@ static int mip4_probe(struct i2c_client *client) 


	ts->gpio_ce = devm_gpiod_get_optional(&client->dev,

					      "ce", GPIOD_OUT_LOW);

	if (IS_ERR(ts->gpio_ce)) {

		error = PTR_ERR(ts->gpio_ce);

		if (error != -EPROBE_DEFER)

			dev_err(&client->dev,

				"Failed to get gpio: %d\n", error);

		return error;

	}

	if (IS_ERR(ts->gpio_ce))

		return dev_err_probe(&client->dev, PTR_ERR(ts->gpio_ce), "Failed to get gpio\n");



	error = mip4_power_on(ts);

	if (error)