Commit 10bf494f authored by Johan Hovold's avatar Johan Hovold Committed by Vinod Koul
Browse files

dmaengine: stm32: dmamux: clean up route allocation error labels 



Error labels should be named after what they do (and not after wherefrom
they are jumped to).

Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Reviewed-by: default avatarAmelie Delaunay <amelie.delaunay@foss.st.com>
Link: https://patch.msgid.link/20251117161258.10679-13-johan@kernel.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent b1b590a5

drivers/dma/stm32/stm32-dmamux.c

+4 −5
Original line number Diff line number Diff line
@@ -118,7 +118,7 @@ static void *stm32_dmamux_route_allocate(struct of_phandle_args *dma_spec, 
		spin_unlock_irqrestore(&dmamux->lock, flags);

		dev_err(&pdev->dev, "Run out of free DMA requests\n");

		ret = -ENOMEM;

		goto error_chan_id;

		goto err_free_mux;

	}

	set_bit(mux->chan_id, dmamux->dma_inuse);

	spin_unlock_irqrestore(&dmamux->lock, flags);
@@ -135,7 +135,7 @@ static void *stm32_dmamux_route_allocate(struct of_phandle_args *dma_spec, 
	dma_spec->np = of_parse_phandle(ofdma->of_node, "dma-masters", i - 1);

	if (!dma_spec->np) {

		dev_err(&pdev->dev, "can't get dma master\n");

		goto error;

		goto err_clear_inuse;

	}



	/* Set dma request */
@@ -167,10 +167,9 @@ static void *stm32_dmamux_route_allocate(struct of_phandle_args *dma_spec, 


err_put_dma_spec_np:

	of_node_put(dma_spec->np);

error:

err_clear_inuse:

	clear_bit(mux->chan_id, dmamux->dma_inuse);



error_chan_id:

err_free_mux:

	kfree(mux);

err_put_pdev:

	put_device(&pdev->dev);