Commit 1131f1e7 authored by Trevor Gamblin's avatar Trevor Gamblin Committed by Jonathan Cameron
Browse files

iio: light: adux1020: make use of regmap_clear_bits(), regmap_set_bits() 



Instead of using regmap_update_bits() and passing the mask twice, use
regmap_set_bits().

Instead of using regmap_update_bits() and passing val = 0, use
regmap_clear_bits().

Suggested-by: default avatarUwe Kleine-König <u.kleine-koenig@baylibre.com>
Signed-off-by: default avatarTrevor Gamblin <tgamblin@baylibre.com>
Acked-by: default avatarUwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://patch.msgid.link/20240617-review-v3-28-88d1338c4cca@baylibre.com


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 0e59dc9e

drivers/iio/light/adux1020.c

+6 −7
Original line number Diff line number Diff line
@@ -539,8 +539,7 @@ static int adux1020_write_event_config(struct iio_dev *indio_dev, 
		 * Trigger proximity interrupt when the intensity is above

		 * or below threshold

		 */

		ret = regmap_update_bits(data->regmap, ADUX1020_REG_PROX_TYPE,

					 ADUX1020_PROX_TYPE,

		ret = regmap_set_bits(data->regmap, ADUX1020_REG_PROX_TYPE,

				      ADUX1020_PROX_TYPE);

		if (ret < 0)

			goto fail;
@@ -748,8 +747,8 @@ static int adux1020_chip_init(struct adux1020_data *data) 


	dev_dbg(&client->dev, "Detected ADUX1020 with chip id: 0x%04x\n", val);



	ret = regmap_update_bits(data->regmap, ADUX1020_REG_SW_RESET,

				 ADUX1020_SW_RESET, ADUX1020_SW_RESET);

	ret = regmap_set_bits(data->regmap, ADUX1020_REG_SW_RESET,

			      ADUX1020_SW_RESET);

	if (ret < 0)

		return ret;
@@ -764,8 +763,8 @@ static int adux1020_chip_init(struct adux1020_data *data) 
		return ret;



	/* Use LED_IREF for proximity mode */

	ret = regmap_update_bits(data->regmap, ADUX1020_REG_LED_CURRENT,

				 ADUX1020_LED_PIREF_EN, 0);

	ret = regmap_clear_bits(data->regmap, ADUX1020_REG_LED_CURRENT,

				ADUX1020_LED_PIREF_EN);

	if (ret < 0)

		return ret;