Commit 1154e430 authored by Jai Luthra's avatar Jai Luthra Committed by Greg Kroah-Hartman
Browse files

usb: typec: tipd: Separate reset for TPS6598x 

Some platforms like SK-AM62, SK-AM62A cannot boot up to prompt if
TPS6598x is cold-reset during unconditionally on probe failures by
sending "GAID" sequence.

The probe can fail initially because USB0 remote-endpoint may not be
probed yet, which defines the usb-role-switch property.

Fixes: d49f9082 ("usb: typec: tipd: add init and reset functions to tipd_data")
Closes: https://lore.kernel.org/linux-usb/vmngazj6si7xxss7txenezkcukqje2glhvvs7ipdcx3vjiqvlk@ohmmhhhlryws/


Signed-off-by: default avatarJai Luthra <j-luthra@ti.com>
Reviewed-by: default avatarRoger Quadros <rogerq@kernel.org>
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20240105-next-tps-fix-v1-1-158cabaec168@ti.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2dd23cc4

drivers/usb/typec/tipd/core.c

+7 −2
Original line number Diff line number Diff line
@@ -1223,11 +1223,16 @@ static int cd321x_reset(struct tps6598x *tps) 
	return 0;

}



static int tps6598x_reset(struct tps6598x *tps)

static int tps25750_reset(struct tps6598x *tps)

{

	return tps6598x_exec_cmd_tmo(tps, "GAID", 0, NULL, 0, NULL, 2000, 0);

}



static int tps6598x_reset(struct tps6598x *tps)

{

	return 0;

}



static int

tps25750_register_port(struct tps6598x *tps, struct fwnode_handle *fwnode)

{
@@ -1545,7 +1550,7 @@ static const struct tipd_data tps25750_data = { 
	.trace_status = trace_tps25750_status,

	.apply_patch = tps25750_apply_patch,

	.init = tps25750_init,

	.reset = tps6598x_reset,

	.reset = tps25750_reset,

};



static const struct of_device_id tps6598x_of_match[] = {