Unverified Commit 118eb2cb authored by Jonas Gorski's avatar Jonas Gorski Committed by Mark Brown
Browse files

spi: bcm63xx: drop wrong casts in probe() 



Both bs->regs and bs->{rx,tx}_io are tagged __iomem, so we shouldn't
cast them to anything else.

Silences the following sparse warning:

drivers/spi/spi-bcm63xx.c:571:22: warning: cast removes address space '__iomem' of expression
drivers/spi/spi-bcm63xx.c:571:19: warning: incorrect type in assignment (different address spaces)
drivers/spi/spi-bcm63xx.c:571:19:    expected unsigned char [noderef] [usertype] __iomem *tx_io
drivers/spi/spi-bcm63xx.c:571:19:    got unsigned char [usertype] *
drivers/spi/spi-bcm63xx.c:572:22: warning: cast removes address space '__iomem' of expression
drivers/spi/spi-bcm63xx.c:572:19: warning: incorrect type in assignment (different address spaces)
drivers/spi/spi-bcm63xx.c:572:19:    expected unsigned char const [noderef] [usertype] __iomem *rx_io
drivers/spi/spi-bcm63xx.c:572:19:    got unsigned char const [usertype] *

Fixes: b42dfed8 ("spi: add Broadcom BCM63xx SPI controller driver")
Signed-off-by: default avatarJonas Gorski <jonas.gorski@gmail.com>
Reviewed-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Link: https://patch.msgid.link/20251116093334.17423-1-jonas.gorski@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent c94f1347

drivers/spi/spi-bcm63xx.c

+2 −2
Original line number Diff line number Diff line
@@ -568,8 +568,8 @@ static int bcm63xx_spi_probe(struct platform_device *pdev) 
	host->auto_runtime_pm = true;

	bs->msg_type_shift = bs->reg_offsets[SPI_MSG_TYPE_SHIFT];

	bs->msg_ctl_width = bs->reg_offsets[SPI_MSG_CTL_WIDTH];

	bs->tx_io = (u8 *)(bs->regs + bs->reg_offsets[SPI_MSG_DATA]);

	bs->rx_io = (const u8 *)(bs->regs + bs->reg_offsets[SPI_RX_DATA]);

	bs->tx_io = bs->regs + bs->reg_offsets[SPI_MSG_DATA];

	bs->rx_io = bs->regs + bs->reg_offsets[SPI_RX_DATA];



	/* Initialize hardware */

	ret = clk_prepare_enable(bs->clk);