Commit 122d57e2 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Lee Jones
Browse files

leds: turris-omnia: Simplify with scoped for each OF child loop 



Use scoped for_each_available_child_of_node_scoped() when iterating over
device nodes to make code a bit simpler.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: default avatarMarek Behún <kabel@kernel.org>
Link: https://lore.kernel.org/r/20240816-cleanup-h-of-node-put-var-v1-16-1d0292802470@linaro.org


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent 42476bce

drivers/leds/leds-turris-omnia.c

+3 −5
Original line number Diff line number Diff line
@@ -452,7 +452,7 @@ static int omnia_mcu_get_features(const struct i2c_client *client) 
static int omnia_leds_probe(struct i2c_client *client)

{

	struct device *dev = &client->dev;

	struct device_node *np = dev_of_node(dev), *child;

	struct device_node *np = dev_of_node(dev);

	struct omnia_leds *leds;

	struct omnia_led *led;

	int ret, count;
@@ -497,12 +497,10 @@ static int omnia_leds_probe(struct i2c_client *client) 
	}



	led = &leds->leds[0];

	for_each_available_child_of_node(np, child) {

	for_each_available_child_of_node_scoped(np, child) {

		ret = omnia_led_register(client, led, child);

		if (ret < 0) {

			of_node_put(child);

		if (ret < 0)

			return ret;

		}



		led += ret;

	}