Commit 122d86aa authored by Cosmin Ratiu's avatar Cosmin Ratiu Committed by Jakub Kicinski
Browse files

net/mlx5e: CT: extract a memcmp from a spinlock section 



This reduces the time the lock is held and reduces contention.

Signed-off-by: default avatarCosmin Ratiu <cratiu@nvidia.com>
Reviewed-by: default avatarDragos Tatulea <dtatulea@nvidia.com>
Signed-off-by: default avatarTariq Toukan <tariqt@nvidia.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/1752009387-13300-3-git-send-email-tariqt@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ade89d1f

drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c

+4 −1
Original line number Diff line number Diff line
@@ -1195,6 +1195,7 @@ mlx5_tc_ct_block_flow_offload_add(struct mlx5_ct_ft *ft, 
	struct flow_action_entry *meta_action;

	unsigned long cookie = flow->cookie;

	struct mlx5_ct_entry *entry;

	bool has_nat;

	int err;



	meta_action = mlx5_tc_ct_get_ct_metadata_action(flow_rule);
@@ -1236,6 +1237,8 @@ mlx5_tc_ct_block_flow_offload_add(struct mlx5_ct_ft *ft, 
	err = mlx5_tc_ct_rule_to_tuple_nat(&entry->tuple_nat, flow_rule);

	if (err)

		goto err_set;

	has_nat = memcmp(&entry->tuple, &entry->tuple_nat,

			 sizeof(entry->tuple));



	spin_lock_bh(&ct_priv->ht_lock);
@@ -1244,7 +1247,7 @@ mlx5_tc_ct_block_flow_offload_add(struct mlx5_ct_ft *ft, 
	if (err)

		goto err_entries;



	if (memcmp(&entry->tuple, &entry->tuple_nat, sizeof(entry->tuple))) {

	if (has_nat) {

		err = rhashtable_lookup_insert_fast(&ct_priv->ct_tuples_nat_ht,

						    &entry->tuple_nat_node,

						    tuples_nat_ht_params);