Commit 126c18a4 authored by Dmitry Antipov's avatar Dmitry Antipov Committed by Takashi Iwai
Browse files

ALSA: seq: fix kvmalloc_array() arguments order 



When compiling with gcc version 14.0.0 20231220 (experimental)
and W=1, I've noticed the following warning:

sound/core/seq/seq_memory.c: In function 'snd_seq_pool_init':
sound/core/seq/seq_memory.c:445:41: warning: 'kvmalloc_array' sizes specified with
'sizeof' in the earlier argument and not in the later argument [-Wcalloc-transposed-args]
  445 |         cellptr = kvmalloc_array(sizeof(struct snd_seq_event_cell), pool->size,
      |                                         ^~~~~~

Since 'n' and 'size' arguments of 'kvmalloc_array()' are multiplied
to calculate the final size, their actual order doesn't affect the
result and so this is not a bug. But it's still worth to fix it.

Signed-off-by: default avatarDmitry Antipov <dmantipov@yandex.ru>
Link: https://lore.kernel.org/r/20231221091605.14660-1-dmantipov@yandex.ru


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent c7e37b07

sound/core/seq/seq_memory.c

+2 −1
Original line number Diff line number Diff line
@@ -442,7 +442,8 @@ int snd_seq_pool_init(struct snd_seq_pool *pool) 
	if (snd_BUG_ON(!pool))

		return -EINVAL;



	cellptr = kvmalloc_array(sizeof(struct snd_seq_event_cell), pool->size,

	cellptr = kvmalloc_array(pool->size,

				 sizeof(struct snd_seq_event_cell),

				 GFP_KERNEL);

	if (!cellptr)

		return -ENOMEM;